No more formatted_* routes in edge rails
-
Trey Bean
I created the patch, really tough :)
I've got a couple of questions, though:
1) Are there any tests/specs that for the plugin in general? I know most plugins don't have them, but kind of expected them here ;)
2) How should this handle backwards compatibility? Removing the formatted_ works in edge/2.3, but doesn't work in 2.2?
Anyway, I'll through my pull request out there, for now. This is one of my first contributions to an open-source project, so feel free to kick me if I'm doing this all wrong.
-
Rick
It generates its tests. Thanks for the patch, but it should really be in a branch for edge rails. There's no way I'm going to break the plugin for some edge change. Edge tends to get new features before adding the deprecations that go into the stable releases.
-
Trey Bean
Ah, I was wondering why that wasn't deprecated in rails 2.2. I guess the deprecation/backwards compatibility will come. Thanks.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.